TrustKit-Android icon indicating copy to clipboard operation
TrustKit-Android copied to clipboard

TrustKit throws IllegalArgumentException

Open iskugor opened this issue 6 years ago • 0 comments

Hello!

Describe the bug

I'm seeing one crash in Google play console:

java.lang.IllegalArgumentException: 
  at com.datatheorem.android.trustkit.config.TrustKitConfiguration.getPolicyForHostname (TrustKitConfiguration.java:90)
  at com.datatheorem.android.trustkit.pinning.TrustManagerBuilder.getTrustManager (TrustManagerBuilder.java:67)
  at com.datatheorem.android.trustkit.TrustKit.getTrustManager (TrustKit.java:390)

https://github.com/datatheorem/TrustKit-Android/blob/master/trustkit/src/main/java/com/datatheorem/android/trustkit/config/TrustKitConfiguration.java#L91

To Reproduce

Unfortunately I cannot reproduce it. It happens to just two users. I just enabled certificate pinning for one default server (and user can use their own server for which pining is not enabled). It looks like server url is not valid, but I validate server url with:

https://github.com/square/okhttp/blob/master/okhttp/src/main/java/okhttp3/HttpUrl.java#L903

before creating http client:

okhttp3.OkHttpClient.Builder httpClient = new okhttp3.OkHttpClient.Builder();
X509TrustManager[] trustManagers = { TrustKit.getInstance().getTrustManager(backendUrl) };

so I'm confused why TrustKit throws exception.

Expected behavior App would not crash.

Or please, let me know how should I handle this exception?

TrustKit configuration

<domain-config cleartextTrafficPermitted="false">
	<domain includeSubdomains="true">*******.***</domain>
	<pin-set>
		<pin digest="SHA-256">********************************************</pin>
		<pin digest="SHA-256">********************************************</pin>
	</pin-set>
	<trustkit-config enforcePinning="true" disableDefaultReportUri="true">
	</trustkit-config>
</domain-config>

App details:

  • App target SDK: 28
  • App language: Java
  • Android version to reproduce the bug: 7.1 and 8

iskugor avatar Mar 19 '19 10:03 iskugor