java-driver icon indicating copy to clipboard operation
java-driver copied to clipboard

Bump Jackson version to la(te)st 2.13.x, 2.13.5

Open cowtowncoder opened this issue 1 year ago • 3 comments

Would increase version further but something in the build has pretty strict check wrt binary compatibility (need to figure out how to increase baseline).

EDIT: Looks like it's org.revapi that compares compatibility, and config file would be core/revapi.json

cowtowncoder avatar Nov 16 '24 03:11 cowtowncoder

@cowtowncoder - any reason jackson is still in 2.13X versions when 2.18 is out for sometime

CtrlAltFly avatar Jan 07 '25 13:01 CtrlAltFly

@CtrlAltFly As per my note, making a bigger jump requires tons of work updating revapi configs and I am not familiar enough to do that. So I ended up submitting just a trivial patch.

I don't know of any other blocker; but if someone tried resolving build/validation problem, I'd be happy to help with any Jackson compatibility issues there might be.

cowtowncoder avatar Jan 07 '25 18:01 cowtowncoder

@cowtowncoder - i agree. going several minor versions can break things. this patch (for now) seems to be a good one to be added for release.

so a 👍🏼 for your PR to be merged!

CtrlAltFly avatar Jan 08 '25 06:01 CtrlAltFly

Kicked off a Jenkins build just to confirm that nothing goes sideways here but I'm really not expecting any problems.

I know that for the 3.x line we have to use 2.13.x since that's the last version that officially supports Java 1.6. Hypothetically we could bump the version for 4.x (since Java8 is our current baseline there) but for foundational libs (like Jackson) it's kinda nice to keep the same version on both 3.x and 4.x; that's what we've done with Netty.

Although... as I look at this now a lot of our usage stems from code we could very likely get rid of. The only major consumer that I see here that would have to stay is the cloud support stuff for DataStax Astra. Hmmmm... that's an interesting idea to explore perhaps.

absurdfarce avatar Apr 28 '25 04:04 absurdfarce

Jenkins run looks clean, calling this good. Thanks for the version bump @cowtowncoder!

absurdfarce avatar Apr 29 '25 16:04 absurdfarce