dbachecks icon indicating copy to clipboard operation
dbachecks copied to clipboard

Use Test-DbaDbQueryStore to test Query Store options

Open tboggiano opened this issue 3 years ago • 2 comments

A New PR

THANK YOU - We love to get PR's and really appreciate your time and help to improve this module

Accepting a PR

Before we accept the PR - please confirm that you have run the tests locally to avoid our automated build and release process failing. You can see how to do that in our wiki

https://github.com/sqlcollaborative/dbachecks/wiki

Please confirm you have 0 failing Pester Tests

[X] There are 0 failing Pester tests

Changes this PR brings

-Testing Query Store for recommended configuration settings. Issue #818. This will replace PR #821.

tboggiano avatar Mar 09 '22 18:03 tboggiano

We should update the required version of dbatools to whatever version this PR for dbatools gets merged into https://github.com/dataplat/dbatools/pull/8219. When I see the next release come out I'll update that as well.

tboggiano avatar Mar 09 '22 18:03 tboggiano

I've updated the required dbatools module to make the changes to the Test-DbaDbQueryStoreOption function are included so that test doesn't fail. https://github.com/dataplat/dbatools/releases/tag/v1.1.77

tboggiano avatar Mar 14 '22 11:03 tboggiano