target-postgres icon indicating copy to clipboard operation
target-postgres copied to clipboard

Updating singer_stream.py to allow schemas without properties

Open lucas opened this issue 3 years ago • 2 comments

While utilizing tap-zendesk (https://github.com/twilio-labs/twilio-tap-zendesk) there are some cases where the generated schema does not include a properties key in the dictionary, causing the properties = self.schema['properties'] to fail.

Defaulting properties to an empty dictionary to prevent exception in these cases without unintended side effects.

lucas avatar Aug 28 '22 16:08 lucas

Quick sense-check on this, is the absence of properties in the schema allowed by the singer spec? I took a quick look, but couldn't find a clear answer, in part because I don't have the data that causes problem. Basically, I'm wondering if the bug is on this end or in the tap you're using.

laurentS avatar Oct 13 '22 14:10 laurentS

@lucas would you be able to merge the main branch into this PR to switch to the new dependency management format (pyproject.toml)?

laurentS avatar Dec 12 '22 11:12 laurentS