code-challenge icon indicating copy to clipboard operation
code-challenge copied to clipboard
verified publisher icon datamade

code challenge submission

Open amitian opened this issue 3 years ago • 1 comments

Overview

My submission for the code challenge!

Notes

I hope this works!

amitian avatar Aug 30 '22 04:08 amitian

Hi, @amitian! Thanks so much for submitting the code challenge. I deeply related to the "Hope this works" line in your PR description – that's often my mindset when I'm programming, too, haha.

I left a few comments for your attention inline. I also noticed a funny behavior when trying out your implementation: When I successfully parse an address, then submit an empty string, the old address is not cleared from the DOM.

Screen Shot 2022-09-09 at 1 38 59 PM

Can you take a look and respond before your interview? I look forward to meeting you! Meanwhile, hope you have a great weekend.

Wow, thank you for catching that! I didn't even think to test that out. It should be fixed now, so the old address will clear after the form submits. I also added an alert box to prevent the user from submitting an empty string--I'd love to learn a subtler/better-looking approach to take, though! a6f3271c0ac4189972819d9eda4570ba921fbd9e

amitian avatar Sep 15 '22 02:09 amitian