datahub icon indicating copy to clipboard operation
datahub copied to clipboard
verified publisher icon datahub-project

feat(openapi): add domain arg

Open dim-ops opened this issue 2 years ago • 3 comments

Add domain arg to OpenApi ingest

Checklist

  • [x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [ ] Links to related issues (if applicable)
  • [ ] Tests for the changes have been added/updated (if applicable)
  • [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

dim-ops avatar Jan 23 '24 16:01 dim-ops

Unfortunately, I believe DataHub domains are different from what you're trying to ingest here. Can you elaborate on exactly what you're trying to accomplish? Are you trying to ingest all your API's OpenAPI domains, or something else?

Yes, I was trying to add the notion of domain to OpenApi as I can do for Glue, Postgres... Because for me, an API can very well be attached to a notion of domain

Example: an API generating data related to advertising should be in the advertising domain.

Don't you agree?

dim-ops avatar Jan 25 '24 12:01 dim-ops

don't need my PR? @asikowitz

dim-ops avatar Jan 26 '24 15:01 dim-ops

Up @asikowitz please 🙏

dim-ops avatar Feb 02 '24 15:02 dim-ops

Sorry for the radio silence. As this should be possible via transformers, I don't believe we need this PR.

asikowitz avatar Feb 23 '24 17:02 asikowitz