datafusion-c icon indicating copy to clipboard operation
datafusion-c copied to clipboard

arm compatibility

Open acookin opened this issue 1 year ago • 3 comments

Use c_char instead of i8 so this is not platform dependent.

acookin avatar Jan 14 '25 13:01 acookin

Do you have a code that shows that the current code has this problem? (How did you find this? Build time warning?)

kou avatar Jan 14 '25 20:01 kou

Do you have a code that shows that the current code has this problem? (How did you find this? Build time warning?)

yes, it was a build time warning building on an arm-based host. Keeping this in draft for now, I will post repro instructions when I get a chance.

acookin avatar Jan 29 '25 20:01 acookin

OK.

We can use arm based GitHub hosted runner: https://github.blog/news-insights/product-news/arm64-on-github-actions-powering-faster-more-efficient-build-systems/

Let's use it in our CI.

kou avatar Jan 29 '25 21:01 kou