databend icon indicating copy to clipboard operation
databend copied to clipboard

Migrate aggregation functions to function-v2

Open RinChanNOWWW opened this issue 3 years ago • 2 comments

Summary

  • [x] combinator distinct. #7615
  • [x] combinator if. #7615
  • [x] count. #7615
  • [x] sum. #7615
  • [x] avg. #7615
  • [x] uniq. #7615
  • [ ] min, max, any. #7787
  • [ ] arg_min, arg_max.
  • [ ] std, stddev, stddev_pop.
  • [ ] covar_samp
  • [ ] covar_pop.
  • [ ] window_funnel.
  • [ ] retention.

something may be helpful

  • [ ] add try_downcast_builder for ValueType. #7838
  • [ ] unit tests for group by. #7845
  • [x] ~add Default for ValueType::Scalar or add default_scalar for ValueType.~

RinChanNOWWW avatar Sep 20 '22 02:09 RinChanNOWWW

  • add Default for ValueType::Scalar or add default_scalar for ValueType.
  • add try_downcast_builder for ValueType.

Are these necessary? cc @sundy-li

RinChanNOWWW avatar Sep 22 '22 14:09 RinChanNOWWW

The Default bound seems not necessary, and not suitable for AnyType. Let's not consider this.

RinChanNOWWW avatar Sep 23 '22 07:09 RinChanNOWWW

stddev and Window funnel assign to @TCeason

TCeason avatar Sep 27 '22 11:09 TCeason