databend icon indicating copy to clipboard operation
databend copied to clipboard

Feature: enable `sse4.2` target_feature when releasing binary in x86_64 architecture

Open sundy-li opened this issue 3 years ago • 1 comments

Summary

Description for this feature.

The SSE 4.2 instructions is very commonly supported in x86_64 arch, we should default enable the sse4.2 target_feature in releasing new releases. For users who want to run Databend with processors that do not support SSE 4.2, they can build Databend from the source.

Refer to clickhouse

cc @Xuanwo @PsiACE sse4.2 is not enabled by default

❯ rustc --print=cfg -C target-cpu=x86-64
debug_assertions
panic="unwind"
target_abi=""
target_arch="x86_64"
target_endian="little"
target_env="gnu"
target_family="unix"
target_feature="fxsr"
target_feature="llvm14-builtins-abi"
target_feature="sse"
target_feature="sse2"
target_has_atomic="16"
target_has_atomic="32"
target_has_atomic="64"
target_has_atomic="8"
target_has_atomic="ptr"
target_has_atomic_equal_alignment="16"
target_has_atomic_equal_alignment="32"
target_has_atomic_equal_alignment="64"
target_has_atomic_equal_alignment="8"
target_has_atomic_equal_alignment="ptr"
target_has_atomic_load_store="16"
target_has_atomic_load_store="32"
target_has_atomic_load_store="64"
target_has_atomic_load_store="8"
target_has_atomic_load_store="ptr"
target_os="linux"
target_pointer_width="64"
target_thread_local
target_vendor="unknown"
unix

sundy-li avatar Sep 17 '22 08:09 sundy-li

OK, let me verify its performance.

PsiACE avatar Sep 19 '22 01:09 PsiACE

https://github.com/datafuselabs/databend/pull/9278

PsiACE avatar Jan 07 '23 04:01 PsiACE