data-diff icon indicating copy to clipboard operation
data-diff copied to clipboard

[to#issue-817]Add support for Clickzetta engine

Open idling11 opened this issue 2 years ago • 7 comments

Add clickzetta driver for data-diff

idling11 avatar Jan 02 '24 08:01 idling11

I am confused that I have clickzetta-connector == 0.8.59 in pypi, why the check is failed when download clickzetta-connector. The Download source is not pypi?
image

idling11 avatar Jan 02 '24 08:01 idling11

Setting a reminder to review this PR later this week!

sungchun12 avatar Jan 02 '24 18:01 sungchun12

I am confused that I have clickzetta-connector == 0.8.59 in pypi, why the check is failed when download clickzetta-connector. The Download source is not pypi?

Can you run poetry lock --no-update ? That will add the dependency to the lockfile

dlawin avatar Jan 03 '24 00:01 dlawin

@sungchun12 I used our test account to test the corresponding ut, and they were all passed. It is currently in the external whitelisting stage and is expected to be ready on January 10. After it is available, we will run it through CI. Thank you so much

idling11 avatar Jan 03 '24 07:01 idling11

@idling11 Can you open source the code for the clickzetta-connector and its license? We'll need it for security review and submit issues if it's not working well with data-diff over time.

sungchun12 avatar Jan 03 '24 17:01 sungchun12

I'll wait until Jan 10 to provide fuller feedback.

sungchun12 avatar Jan 03 '24 17:01 sungchun12

@idling11 Can you open source the code for the clickzetta-connector and its license? We'll need it for security review and submit issues if it's not working well with data-diff over time.

OK, I have submitted it to the internal approval process of open source. I will give you the link after the approval is passed.

idling11 avatar Jan 04 '24 03:01 idling11

This pull request has been marked as stale because it has been open for 60 days with no activity. If you would like the pull request to remain open, please comment on the pull request and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Mar 04 '24 06:03 github-actions[bot]

Although we are closing this pull request as stale, it's not gone forever. PRs can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.

github-actions[bot] avatar Mar 12 '24 06:03 github-actions[bot]