datacontract-cli icon indicating copy to clipboard operation
datacontract-cli copied to clipboard
Published 2 months ago • verified publisher icon datacontract

Support for MS Sqlserver

Open RobertLD opened this issue 1 year ago • 8 comments

Our company is actively pursuing stricter guarantees on cross-team data via the data contract-cli. We currently make use of MS SqlServer and would like to know if this is supported within the data contract cli?

RobertLD avatar May 14 '24 15:05 RobertLD

Currently, it is not implemented, but should not be too difficult to implement, as soda-core supports ms sqlserver.

As a precondition, we'd need to add sqlserver to the server specification https://github.com/datacontract/datacontract-specification/?tab=readme-ov-file#server-object

jochenchrist avatar May 14 '24 15:05 jochenchrist

Would you (or your team) have some capacity to contribute a Pull-Request?

jochenchrist avatar May 14 '24 16:05 jochenchrist

I'm sure I can find some time to pull the code and investigate, hopefully sometime this week or next.

RobertLD avatar May 14 '24 16:05 RobertLD

Added sqlserver to data contract specification: https://github.com/datacontract/datacontract-specification/?tab=readme-ov-file#sql-server-server-object

jochenchrist avatar May 15 '24 12:05 jochenchrist

Added sqlserver to data contract specification: https://github.com/datacontract/datacontract-specification/?tab=readme-ov-file#sql-server-server-object

Including the supporting code, or just preparing the doc?

I've cloned the repo last night and was beginning to poke around

RobertLD avatar May 15 '24 12:05 RobertLD

Jochen added the server type to the specification.

What is now missing is adding support in the CLI within the python code base. Do you want to have a try for this @RobertLD ? It should be straight forward mapping to soda sqlserver type.

simonharrer avatar May 15 '24 14:05 simonharrer

I'll take a crack at it once I get my bearings

RobertLD avatar May 15 '24 15:05 RobertLD

Added sqlserver to data contract specification: https://github.com/datacontract/datacontract-specification/?tab=readme-ov-file#sql-server-server-object

Jochen added the server type to the specification.

What is now missing is adding support in the CLI within the python code base. Do you want to have a try for this @RobertLD ? It should be straight forward mapping to soda sqlserver type.

I've published a rough PR for the changes because the specification published earlier for SQLServer doesn't match exactly what I would expect (namely missing the driver, etc.)

With some guidance or an update of the spec I can continue work on it https://github.com/datacontract/datacontract-cli/pull/204

ty

RobertLD avatar May 15 '24 17:05 RobertLD

Completed in PR #204

RobertLD avatar May 25 '24 01:05 RobertLD