helm-diff icon indicating copy to clipboard operation
helm-diff copied to clipboard

Helm diff fails when --set variables start with a capital letter

Open ctr26 opened this issue 3 years ago • 3 comments

Input:

helm diff --suppress-secrets upgrade jupyterhub jupyterhub/jupyterhub --version 1.2.0 --namespace jupyterhub -f .helmsman-tmp/tmp748608288/327616155config.yaml --set hub.config.GitHubOAuthenticator.oauth_callback_url="test"

Error:

interface conversion: interface {} is []interface {}, not map[string]interface {}

Input and lower-case the G:

helm diff --suppress-secrets upgrade jupyterhub jupyterhub/jupyterhub --version 1.2.0 --namespace jupyterhub -f .helmsman-tmp/tmp748608288/327616155config.yaml --set hub.config.gitHubOAuthenticator.oauth_callback_url="test"

Runs successfully

I'm on the latest helm and helm-diff versions

ctr26 avatar Feb 26 '22 10:02 ctr26

@ctr26 Hey. I believe helm-diff just passes --set flags to helm template so I don't think there's any fault on helm-diff here. Isn't it a bug in jupyterhub chart? Would you mind confirming if that reproduces with other charts?

mumoshu avatar Feb 26 '22 10:02 mumoshu

It's bad practise by jupyterhub to sentence-case v camelcase for sure. I'll mention the bug in the main helm repo. Thanks

ctr26 avatar Feb 26 '22 13:02 ctr26

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 12 '22 14:06 stale[bot]