ucx icon indicating copy to clipboard operation
ucx copied to clipboard

Adds type hints with `CrawlerBase` for the table crawlers where required #2819

Open pritishpai opened this issue 1 year ago • 3 comments

## Changes Adds type hints with CrawlerBase for the table crawlers where required #2819

Linked issues

(https://github.com/databrickslabs/ucx/pull/2813/files#r1786418356)

pritishpai avatar Oct 03 '24 15:10 pritishpai

✅ 43/43 passed, 3 skipped, 2h22m32s total

Running from acceptance #6513

github-actions[bot] avatar Oct 03 '24 16:10 github-actions[bot]

why do we need this?

I request Pritish to solve the missing type hint for the table crawlers, what you suggested in a comment is a good approach

JCZuurmond avatar Oct 04 '24 06:10 JCZuurmond

Used superclass CrawlerBase for type hints. Had to add a placeholder method 'load_one' for one of the usages of TableCrawler

pritishpai avatar Oct 04 '24 16:10 pritishpai