ucx icon indicating copy to clipboard operation
ucx copied to clipboard

Add RemoveAfter tag on all UCX jobs for cleanup

Open pritishpai opened this issue 1 year ago • 1 comments

Changes

Add RemoveAfter tag on all UCX jobs, so that they're cleaned up by watchdog even if they are in the approved instance pool

Linked issues

Partial work from #977

Functionality

  • [ ] added relevant user documentation
  • [ ] added new CLI command
  • [ ] modified existing command: databricks labs ucx ...
  • [ ] added a new workflow
  • [ ] modified existing workflow: ...
  • [ ] added a new table
  • [ ] modified existing table: ...

Tests

  • [ ] manually tested
  • [ ] added unit tests
  • [ ] added integration tests
  • [ ] verified on staging environment (screenshot attached)

pritishpai avatar May 15 '24 17:05 pritishpai

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.23%. Comparing base (9107005) to head (eae97d0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1699   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files          88       88           
  Lines       11208    11208           
  Branches     1981     1981           
=======================================
  Hits        10002    10002           
  Misses        823      823           
  Partials      383      383           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 15 '24 17:05 codecov[bot]

this looks good to me - we will need changes in watchdog as well

Yes. This only partly covers the issue. Will not be closing the main issue until watchdog changes are pushed.

pritishpai avatar May 17 '24 18:05 pritishpai

✅ 168/168 passed, 1 flaky, 25 skipped, 2h2m43s total

Flaky tests:

  • 🤪 test_running_real_migrate_groups_job (4m35.336s)

Running from acceptance #3290

github-actions[bot] avatar May 17 '24 18:05 github-actions[bot]