mosaic icon indicating copy to clipboard operation
mosaic copied to clipboard

Fix typo in BNG lettermap

Open tompeterken-os opened this issue 2 years ago • 4 comments

The tile SZ appears twice in letterMap in BNGIndexSystem.scala. One instance should read "HZ" instead. As a result, features in the HZ square are given "SZ" grid indices.

This PR makes a single update to letterMap, correcting the typo.

(Probably not spotted before now because only Fair Isle appears in the HZ square!)

Signed-off by Tom Peterken [email protected]

tompeterken-os avatar Sep 19 '23 09:09 tompeterken-os

Hi @tompeterken-os , in order for us to proceed it is sufficient to add a comment to this PR with your sign-off (Eg. Signed-off-by: Joe Smith <[email protected]>). We need this to make sure you are aware of the current license, and that you agree with it. :)

milos-colic avatar Oct 04 '23 16:10 milos-colic

Codecov Report

Merging #433 (e69fb94) into main (19f2e9f) will increase coverage by 0.01%. Report is 160 commits behind head on main. The diff coverage is 97.56%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   95.01%   95.02%   +0.01%     
==========================================
  Files         198      198              
  Lines        5658     5692      +34     
  Branches      178      175       -3     
==========================================
+ Hits         5376     5409      +33     
- Misses        282      283       +1     
Files Coverage Δ
...bricks/labs/mosaic/core/index/BNGIndexSystem.scala 99.01% <100.00%> (ø)
...abricks/labs/mosaic/core/index/H3IndexSystem.scala 97.59% <97.50%> (-0.37%) :arrow_down:

codecov[bot] avatar Oct 04 '23 16:10 codecov[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 27 '23 20:11 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 27 '23 20:11 CLAassistant