Added tag filtering and speedup
Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.
Comparison is base (
dfc9c3f) 92.90% compared to head (511f7c9) 92.40%.
| Files | Patch % | Lines |
|---|---|---|
| discoverx/explorer.py | 50.00% | 4 Missing :warning: |
| discoverx/table_info.py | 87.50% | 1 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 92.90% 92.40% -0.51%
==========================================
Files 11 11
Lines 874 895 +21
Branches 151 158 +7
==========================================
+ Hits 812 827 +15
- Misses 34 39 +5
- Partials 28 29 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 92.40% <76.00%> (-0.51%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This feature would assist my use case where a customer wants to be able to arbitrarily group tables into categories (as lists) and apply maintenance jobs based on the category. Different categories will exist side by side each other in any schema and therefore pattern based matching (without restrictive table naming conventions) won't work. A solution would be to use table tags allowing us to use patterns + table tags and keep the convenience and functionality of discoverx to operate over lists of tables.