databricks-sql-python icon indicating copy to clipboard operation
databricks-sql-python copied to clipboard

Relax `pyarrow` pin

Open dhirschfeld opened this issue 1 year ago • 2 comments

Arrow 15 has been released and it woudl be good to be able to use it.

https://arrow.apache.org/blog/2024/01/21/15.0.0-release/

dhirschfeld avatar Apr 26 '24 03:04 dhirschfeld

Hi @dhirschfeld! Thank you for contributing! I should ask you to do two things before we can proceed:

  • please sign off your commits. To fix existing comits in this branch - use git rebase -i main
  • please update poetry.lock file as well using poetry lock command

kravets-levko avatar Apr 26 '24 05:04 kravets-levko

please sign off your commits

In the linked docs it says:

you can sign your commit automatically with git commit -s

...but my commits are cryptographically signed, so do I still need the Signed-off-by: footer?

image

dhirschfeld avatar Apr 26 '24 06:04 dhirschfeld

@kravets-levko - the commits should all be signed off now...

dhirschfeld avatar May 05 '24 23:05 dhirschfeld

ping @kravets-levko - any objections?

dhirschfeld avatar May 11 '24 12:05 dhirschfeld

...but my commits are cryptographically signed, so do I still need the Signed-off-by: footer?

Hey @dhirschfeld this is a bit tangential to your PR but in case your curious: the cryptographic signing and the Signed-off-by commit text actually serve different purposes. The "verified" badge verifies that it was your computer that generated the code. Whereas the Signed-off-by header is more about legal attribution. The "verified" header is nice to have but not required by this repository. The Signed-off-by is mandatory to protect the maintainers from legal challenges if someone attempts to commit code to this repository that they weren't authorized to open-source.

susodapop avatar May 28 '24 19:05 susodapop

Note that this PR will also close https://github.com/databricks/databricks-sql-python/issues/390

susodapop avatar May 28 '24 19:05 susodapop