updated Dockerfile so tests would pass and image would build
To follow up on Issue 166, the current Dockerfile fails to build as the tests do not pass.
I have made the following changes and it now builds (and runs the CLI) successfully:
- The packages listed in
tox-requirements.txtare required for the tests to run (and pass), so the Dockerfile now installs them- I bumped the versions of several of these packages to resolve errors regarding
pytest-djangoandpyflakes - there is still a warning that prospector requires a newer version of pylint, but all tests are now passing
- I bumped the versions of several of these packages to resolve errors regarding
-
clickandtabulatepackages seem to be required by the main codebase, so I added them todev-requirements.txtso they are installed (and stick around) - In order to satisfy pyroma, the Apache license is now listed in the classifiers in
setup.py
To save space in the image:
- All
pip installcommands now have the--no-cache-diroption - All packages listed in
tox-requirements.txtare now removed after the tests have been run
Codecov Report
Merging #167 into master will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 83.38% 83.38%
=======================================
Files 30 30
Lines 1938 1938
=======================================
Hits 1616 1616
Misses 322 322
| Impacted Files | Coverage Δ | |
|---|---|---|
| setup.py | 0% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8637478...3f056a7. Read the comment docs.
Any idea when this will be merged?
@hagridaaron, as it is, this PR isn't ready to merge (merge conflicts and changes to workspace/api.py. Is your goal just to make the docker image build?
On this fork I get:
executor failed running [/bin/sh -c pip install --upgrade --no-cache-dir pip && pip install --no-cache-dir -r dev-requirements.txt -r tox-requirements.txt && pip list && ./lint.sh && pip install --no-cache-dir . && pytest tests && pip uninstall -y -r tox-requirements.txt]: exit code: 1