google-cloud icon indicating copy to clipboard operation
google-cloud copied to clipboard

Use securekey-textarea widget for SA json fields

Open GnsP opened this issue 1 year ago • 2 comments

Changes the widget type for SA json fields from textbox to secure-textarea

Please notice the shield icon in the SA json field. Clicking the shield lets the user select one of the secure keys defined in the namespace.

A corresponding PR in cdap-ui adds the securekeys tab in Namespace Admin and also makes the securekey-textarea widget non-editable (so that the user will only be able to add the value as a secure macro).

Screenshot 2024-05-13 at 10 21 28 AM

GnsP avatar May 13 '24 03:05 GnsP

Can you please add the screenshot in the PR description on how the change was tested?

Added a screenshot.

GnsP avatar May 13 '24 04:05 GnsP

Can you please add the screenshot in the PR description on how the change was tested?

Added a screenshot.

What will be the case for existing pipelines? How will the UI look like? Have we tested it? Also since it has been using textarea from sometime now, do we have a PM approval?

itsankit-google avatar May 13 '24 04:05 itsankit-google