data-forge-indicators icon indicating copy to clipboard operation
data-forge-indicators copied to clipboard

Dev dependecy chai required in production?

Open Tauri28 opened this issue 4 years ago • 3 comments

I have notices, that the production code is using chai for testing and I am getting Error: Cannot find module 'chai' since it is listed under devDependencies

Tauri28 avatar Mar 29 '21 19:03 Tauri28

Ok thanks for letting me know.

Feel free to move the code that depends on chai or add chai to normal dependencies. If you submit a PR I'll accept and publish a new version.

ashleydavis avatar Mar 30 '21 07:03 ashleydavis

I'm receiving the same error. I'll take a look at it later and submit a PR if I can.

thegafo avatar Oct 05 '21 14:10 thegafo

Please feel to remove chai for assertions and just throw exceptions... that way we can remove chai as a dependency altogether.

ashleydavis avatar Oct 11 '21 04:10 ashleydavis