Warn users when they approve share requests with Write/Modify permissions

[petrkalos]

Currently the share view indicates the requested permissions but given that customers are used to Read-only nature of data.all it might be good to implement a warning mechanism to increase awareness.

My suggestions, first one is much simpler to implement but the second is more assertive.

1. Only for Write/Modify share requests display a sizeable warning as a subheader in the ShareView

2. Only for Write/Modify share requests create a confirmation pop-up when clicking the Approve button

[dlpzx]

I kind of like the second one better, but waiting to see what the rest think

[anushka-singh]

I like option 2 better!

[voidwisp]

I like option 2.. I prefer a user confirms explicitly they definitely want write permissions to be granted. Then there's no excuse 'I didn't see it'

[TejasRGitHub]

I like option 2 as well.

@petrkalos , would this dialog box show for all kind of approvals ( i.e. Read-Only, Write /Modify ) ?

[petrkalos]

I like option 2 as well.

@petrkalos , would this dialog box show for all kind of approvals ( i.e. Read-Only, Write /Modify ) ?

No I am thinking only if it's not read-only

[petrkalos]

@zsaltys @TejasRGitHub as discussed see #1568