TYP: Type annotations, part 4
Follow-up to #288 Get mypy mostly green everywhere except torch.
Why didn't you address those while it was still open? Then I could've explained my reasons for it, which would have saved us both a lot time.
I couldn't review that PR in time, apologies.
Seeing large portions of my work being deleted with comments like "holy overengineering Batman!" is pretty frustrating, to say the least.
I apologise, that was an emotional comment and I should not have made it.
@jorenham can we get some traction back into this?
@jorenham can we get some traction back into this?
I'll take a look tonight
@jorenham I've reverted my changes re. shape-typing, namespace generics, super-specific dtypes() return value annotations, plus a bunch of other minor things. I believe there are no outstanding issues but I may have missed some. Ready for another iteration of review.
@ev-br ready for merge
sorry for the wait, thank you both!