array-api-compat icon indicating copy to clipboard operation
array-api-compat copied to clipboard

TYP: Type annotations, part 4

Open crusaderky opened this issue 10 months ago • 5 comments

Follow-up to #288 Get mypy mostly green everywhere except torch.

crusaderky avatar Apr 18 '25 13:04 crusaderky

Why didn't you address those while it was still open? Then I could've explained my reasons for it, which would have saved us both a lot time.

I couldn't review that PR in time, apologies.

Seeing large portions of my work being deleted with comments like "holy overengineering Batman!" is pretty frustrating, to say the least.

I apologise, that was an emotional comment and I should not have made it.

crusaderky avatar Apr 21 '25 09:04 crusaderky

@jorenham can we get some traction back into this?

crusaderky avatar May 15 '25 08:05 crusaderky

@jorenham can we get some traction back into this?

I'll take a look tonight

jorenham avatar May 16 '25 09:05 jorenham

@jorenham I've reverted my changes re. shape-typing, namespace generics, super-specific dtypes() return value annotations, plus a bunch of other minor things. I believe there are no outstanding issues but I may have missed some. Ready for another iteration of review.

crusaderky avatar May 19 '25 12:05 crusaderky

@ev-br ready for merge

crusaderky avatar May 19 '25 14:05 crusaderky

sorry for the wait, thank you both!

lucascolley avatar Jun 04 '25 14:06 lucascolley