Allow for specification of dat secret storage directory.
Thanks! I moved the secret keys to an option in the second argument. Can you update this PR to reflect that? Should make it a bit simpler =).
It'd be great to have a test for this as well! Please also make sure you run npm test on your machine and the syntax is all okay.
Codecov Report
Merging #193 into master will decrease coverage by
0.45%. The diff coverage is50%.
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
- Coverage 84.86% 84.41% -0.46%
==========================================
Files 7 7
Lines 304 308 +4
==========================================
+ Hits 258 260 +2
- Misses 46 48 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| index.js | 100% <ø> (ø) |
:arrow_up: |
| lib/storage.js | 68% <50%> (-3.43%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 20e7353...3a18e96. Read the comment docs.
Are the tests passing locally for you? Look like they are hanging on travis but not sure why.
It's a bit easier to review if you just push a new commit rather than squishing all the changes. I forget what I was commenting on last time, so nice to see the diff =)
Looks good if you can just move that test over to test it on sharing. 🎉