knit icon indicating copy to clipboard operation
knit copied to clipboard
verified publisher icon dask

Always set KNIT_LANG, even if envvars passed in

Open jcrist opened this issue 8 years ago • 2 comments

jcrist avatar Feb 06 '18 17:02 jcrist

OK, reasonable.

martindurant avatar Feb 06 '18 17:02 martindurant

If it's not set, things fail in the application master here, as a null reference error occurs on this line: https://github.com/dask/knit/blob/master/knit_jvm/src/main/scala/io/continuum/knit/ApplicationMaster.scala#L155. As such, I'm a bit confused why this test passed before. Perhaps changes to the environment variables persisted? I don't really have time right now to debug the tests, but this fix is valid.

jcrist avatar Feb 06 '18 17:02 jcrist