Enable overwrites of default environment variables
Should solve https://github.com/dask/dask-kubernetes/issues/873
Was sure you'd ask that :smile: I'm a bit unsure about that though.
Changing the Scheduler address from the default address will likely lead to that Cluster being broken in the CI test? We could test though for a custom non-default Dask Worker name I guess? What do you think?
We could test though for a custom non-default Dask Worker name I guess?
Yep that sounds like a great way to test it.
@jacobtomlinson sorry for the delay, was busy with other things. PR should now be ready; I included some tests that will use the apparently previously unused "simpleworkergroup.yaml" for deploying an additional worker group that overrides the envvar "DASK_WORKER_NAME". In the tests, it will check if the DASK_SCHEDULER still is intact.
@jonded94 @jacobtomlinson - Does build_job_pod_spec also need to be updated to allow overwriting the default environment variables?
Ah, sure, sorry, will do that too tomorrow. This one doesn't need a test though (overriding the scheduler address is anyways a bit weird to test).