dask-kubernetes icon indicating copy to clipboard operation
dask-kubernetes copied to clipboard

Enable overwrites of default environment variables

Open jonded94 opened this issue 2 years ago • 2 comments

Should solve https://github.com/dask/dask-kubernetes/issues/873

jonded94 avatar Mar 08 '24 14:03 jonded94

Was sure you'd ask that :smile: I'm a bit unsure about that though.

Changing the Scheduler address from the default address will likely lead to that Cluster being broken in the CI test? We could test though for a custom non-default Dask Worker name I guess? What do you think?

jonded94 avatar Mar 08 '24 16:03 jonded94

We could test though for a custom non-default Dask Worker name I guess?

Yep that sounds like a great way to test it.

jacobtomlinson avatar Mar 11 '24 11:03 jacobtomlinson

@jacobtomlinson sorry for the delay, was busy with other things. PR should now be ready; I included some tests that will use the apparently previously unused "simpleworkergroup.yaml" for deploying an additional worker group that overrides the envvar "DASK_WORKER_NAME". In the tests, it will check if the DASK_SCHEDULER still is intact.

jonded94 avatar Apr 02 '24 12:04 jonded94

@jonded94 @jacobtomlinson - Does build_job_pod_spec also need to be updated to allow overwriting the default environment variables?

creste avatar Apr 02 '24 20:04 creste

Ah, sure, sorry, will do that too tomorrow. This one doesn't need a test though (overriding the scheduler address is anyways a bit weird to test).

jonded94 avatar Apr 02 '24 20:04 jonded94