dask-kubernetes icon indicating copy to clipboard operation
dask-kubernetes copied to clipboard

Remove type suffixes

Open jacobtomlinson opened this issue 3 years ago • 0 comments

When creating a DaskCluster with dask_kubernetes.experimental.KubeCluster the name you specify gets -cluster added onto the name.

from dask_kubernetes.experimental import KubeCluster

cluster = KubeCluster(name='foo')
$ kubectl get dsk
NAME                  AGE
foo-cluster           7m32s

https://github.com/dask/dask-kubernetes/blob/ffa43642439973409d3714c9814846413ce7d049/dask_kubernetes/experimental/kubecluster.py#L163

Also the service that gets created has -service added to the end of its name.

$ kubectl get svc -l dask.org/cluster-name=foo-cluster
NAME                          TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)             AGE
foo-cluster-service           ClusterIP   10.96.223.217   <none>        8786/TCP,8787/TCP   8m27s

https://github.com/dask/dask-kubernetes/blob/ffa43642439973409d3714c9814846413ce7d049/dask_kubernetes/operator/operator.py#L39

Both of these feel a little redundant given their resource types and also require a little working around to convert the names back and forth. I think it would be good to remove these suffixes.

jacobtomlinson avatar Aug 11 '22 14:08 jacobtomlinson