dask-jobqueue icon indicating copy to clipboard operation
dask-jobqueue copied to clipboard

Remove deprecated parameters `env_extra`, `extra`, `job_extra`

Open jolange opened this issue 3 years ago • 3 comments

The parameters have been renamed in

  • #575
  • #576
  • #577

but are still respected, when the newly named parameters are not set. Deprecation warnings are issued if they are still used. For context, see also #323.

We still need to decide when to finally remove them: Maybe at a fixed date or in terms of number of releases?

jolange avatar Aug 25 '22 06:08 jolange

Thanks @jolange for opening this issue, and thanks again for all you work!

As you've probably seen, release are not quite regular here... So a number of releases could take years.

What I propose is to make a new major release of dask-jobqueue soon (in the coming days or week), version 0.8.0, as a good number of changes has been commited. Then we could agree on a maximum delay before removing the old parameters. What about 6 months? Or maybe one year?

We could say we need to remove the old parameters and deprecation message either after 6 months, either if we plan a new major release until then?

guillaumeeb avatar Aug 25 '22 10:08 guillaumeeb

I propose is to make a new major release of dask-jobqueue soon (in the coming days or week), version 0.8.0

Sounds good.

What about 6 months? Or maybe one year?

6 months sounds enough to me, personally. Of course, given that the deprecation warning has been included in a published release for some time, which should be the case with your plans for a new release.

jolange avatar Aug 26 '22 08:08 jolange

0.8.0 version of dask-jobqueue released today. So this issue will be due in 6 months from now, or at the next major release.

guillaumeeb avatar Aug 29 '22 11:08 guillaumeeb