dask-glm Add n_iter_ attribute to estimators

After this is merged, Dask-ML must be adapted to this change as well.

https://github.com/dask/dask-ml/blob/master/dask_ml/linear_model/glm.py#L187

Solves #77.

Mar 20 '19 12:03 pentschev

cc @jrbourbeau @cicdw

Mar 20 '19 18:03 mrocklin

Minor comment: could you please add an n_iter_ attribute to the estimator docstrings

Yes, thanks for pointing that I forgot it.

Also, as you mentioned, these changes will cause breakage in dask-ml. Do you have an interest in updating the estimators over there too? Definitely no obligation though, just wanted to check

Yes, I planned to do that once this was merged, I think there's no point in already opening an PR there before this gets reviewed here.

Mar 22 '19 21:03 pentschev

Yes, I planned to do that once this was merged

Awesome, thank you @pentschev

Mar 25 '19 20:03 jrbourbeau

From my side, this is ready for another review/merge.

Mar 25 '19 21:03 pentschev

Are we good to merge this?

Apr 09 '19 08:04 pentschev