dask-gateway icon indicating copy to clipboard operation
dask-gateway copied to clipboard

Helm chart: "imagePullSecrets" missing for backend

Open erl987 opened this issue 4 years ago • 4 comments

Both gateway and controller have an option to specify imagePullSecrets in the values.yaml file of dask-gateway. This is however missing for backend.

I think that this is much more important for the backend because it will often be customized? The cloud provider I am using is by default controlling the access to the image repository by a Kubernetes secret.

So, I would appreciate if this missing configuration could be added.

Any suggestions on how I can work around this in the meanwhile?

/Ralf

erl987 avatar Feb 12 '21 13:02 erl987

Ok, a workaround is to use extraPodConfig:

dask-gateway:
  gateway:
    backend:
      scheduler:
        extraPodConfig:
          imagePullSecrets:
            - name: default-secret

In similar way this is to be done for the worker.

erl987 avatar Feb 12 '21 15:02 erl987

Another Solution would be to add your ImagePullSecret to the ServiceAccounts

https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/

victorgetz avatar Mar 30 '21 18:03 victorgetz

Sorry nobody got back to you here. I'm glad you found a workaround.

I think exposing it as a regular config option inline with the other components makes sense. Do you have any interest in submitting a PR?

jacobtomlinson avatar Mar 31 '21 08:03 jacobtomlinson

Thanks for the suggestion, but I think I am not deeply enough into Kubernetes to fix this myself.

erl987 avatar Apr 13 '21 09:04 erl987