dask-docker icon indicating copy to clipboard operation
dask-docker copied to clipboard
verified publisher icon dask

Observations from 2021.8.1 automatic release

Open jrbourbeau opened this issue 4 years ago • 7 comments

A couple unexpected things happened with the latest automatic release procedure:

  • [x] GitHub actions didn't run when the pull request was initially opened (though when I pushed an empty commit, GHA ran as expected). I checked https://www.githubstatus.com/ and there were know reported issues with GitHub actions during this time. xref https://github.com/dask/dask-docker/pull/178
  • [ ] Even though the automerge label was applied to the PR, it wasn't automatically merged after all CI checks passed. xref https://github.com/dask/dask-docker/pull/178
  • [x] Twice as many build CI jobs ran on https://github.com/dask/dask-docker/pull/178. I suspect this is because we're triggering on both pull_request and push events https://github.com/dask/dask-docker/blob/e82ac06b362319833954ae64687061606f22b924/.github/workflows/build.yml#L3
  • [x] The PR which was automatically created updated the release: XXXX.XX.X field in build/docker-compose.yml but not .github/workflows/build.yml (xref https://github.com/dask/dask-docker/pull/179). EDIT: fixed by https://github.com/dask/dask-docker/pull/181
  • [x] Images for the new 2021.8.1 release aren't appearing on docker hub (https://hub.docker.com/r/daskdev/dask/tags?page=1&ordering=last_updated) (I think this is related to our autotagging action)

jrbourbeau avatar Aug 21 '21 16:08 jrbourbeau

For reference, since our build workflow will push to docker hub on push events with a new tag

https://github.com/dask/dask-docker/blob/3362618f21512dfb66a42877ccd846375e611a66/.github/workflows/build.yml#L78

I ended up manually deleting the 2021.8.1 tag (which was generated from the autotag workflow) and pushing an empty commit to main with a new 2021.8.1 tag (https://github.com/dask/dask-docker/commit/3362618f21512dfb66a42877ccd846375e611a66). This resulted in docker images for the new release being published

jrbourbeau avatar Aug 21 '21 17:08 jrbourbeau

Thanks for writing this up @jrbourbeau. I'll take a look at these.

jacobtomlinson avatar Aug 23 '21 10:08 jacobtomlinson

Curious how many of these are still issues

jakirkham avatar Feb 28 '22 18:02 jakirkham

IIUC all of the unchecked boxes in the original post are still valid

jrbourbeau avatar Feb 28 '22 23:02 jrbourbeau

I've fixed up a few things and checked a few boxes in the post above that I can confirm as resolved.

The last outstanding one is the auto merge, I'm not sure if this is fixed by the other changes I've made so let's wait until the next release and see what happens. cc @jrbourbeau @jsignell.

jacobtomlinson avatar Mar 23 '22 10:03 jacobtomlinson

ping @jrbourbeau @jsignell how did things go with the latest release?

I see some extra changes were pushed to the PR so I'm guessing the find and replace still isn't working quite right, and the automerge didn't work. Is there anything else?

jacobtomlinson avatar Apr 04 '22 08:04 jacobtomlinson

Yeah, that's correct. I also noticed that the autotag workflow did assign a 2022.4.0 tag, but assigning that tag didn't result in us pushing Docker images to Docker Hub or ghcr.io. As of now the latest images available are for 2022.3.0. I should also note that deleted the 2022.4.0 tag which was automatically added and manually re-added the tag myself to see if that would help, but it did not

jrbourbeau avatar Apr 04 '22 21:04 jrbourbeau