dask-cloudprovider icon indicating copy to clipboard operation
dask-cloudprovider copied to clipboard

find_address_timeout removed: why?

Open dpmccabe opened this issue 3 years ago • 1 comments

Describe the issue:

The find_address_timeout argument was removed from ecs.Task in 7c84ad7 with no apparent replacement.

Minimal Complete Verifiable Example:

Task(find_address_timeout=180, ...)

Anything else we need to know?:

If specifying this argument is no longer the correct way to prevent timeouts, then what is? That commit did not update any documentation regarding this logic.

dpmccabe avatar Jan 20 '23 17:01 dpmccabe

This option was removed in #373 because it was no longer needed.

Previously we read the logs until the scheduler address was printed. This could potentially never happen so we added a timeout.

The new implementation uses the ECS API to find the address which always returns a valid address. Therefore we no longer needed a timeout.

It would help if you could share more about the problem you are running into and why you are looking for this timeout.

jacobtomlinson avatar Jan 24 '23 12:01 jacobtomlinson