fix(strategy-tests): create some identity transitions rather than none on error

[pauldelucia]

Issue being fixed or feature implemented

In strategy tests, when creating identity state transitions, if there was an error creating one transition but success in creating others, we would return 0 transitions.

What was done?

Now we return a vector of results from create_identity_state_transitions and return a vector of errors from state_transitions_for_block.

How Has This Been Tested?

TUI

Breaking Changes

Checklist:

• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have added or updated relevant unit/integration/functional/e2e tests
• [x] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• [x] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• [ ] I have assigned this pull request to a milestone