dash-network-deploy icon indicating copy to clipboard operation
dash-network-deploy copied to clipboard

Deploy tool can fail to unban masternodes if collateral address contains no fee UTXOs

Open strophy opened this issue 3 years ago • 0 comments

Expected Behavior

Deploy tool should unban all banned masternodes without any issues

Current Behavior

The collateral address is also used as the fee source address when creating ProUpServTx in the mn-init role. In rare cases, the fee UTXO may have been spent and moved to a change address due to previous unban operations or operations on the testnet wallet on other clients.

Possible Solution

Deploy tool should check there is balance to pay for fees and create it if necessary before attempting to unban nodes. Alternatively, we could use a single fee source address, which would probably speed up mn-init because only one fee funding transaction would be necessary, rather than as many transactions as there are masternodes.

Steps to Reproduce (for bugs)

Context

Your Environment

  • Version used:
  • Environment name and version (e.g. Chrome 39, node.js 5.4):
  • Operating System and version (desktop, server, or mobile):
  • Link to your project:

strophy avatar Jun 27 '22 11:06 strophy