stroke-ae icon indicating copy to clipboard operation
stroke-ae copied to clipboard

find a mistake in the code

Open DanielCho-HK opened this issue 3 years ago • 1 comments

Is there a typo in the code on line 73 of bezierae.py ? C = torch.cat([c_final[-1, 0], c_final[-1, 0]], 1) should be changed to C = torch.cat([c_final[-1, 0], c_final[-1, 1]], 1)

DanielCho-HK avatar Apr 06 '22 13:04 DanielCho-HK

It's an old code and I no longer maintain this. But, looking at a glance, I think you are right. It seems I did not include the LSTM backward state in c_final for computing the latent. However, it's correctly done for h_final. So I believe it is still getting a lot of information about the LSTM's end state (from h; both forward and backward). Empirically, I think it wouldn't make much difference. It may only increase the performance a bit, if at all.

Since I no longer maintain this, you may correct it yourself or send a PR.

dasayan05 avatar Apr 07 '22 18:04 dasayan05