fbRads icon indicating copy to clipboard operation
fbRads copied to clipboard

export fbad_request function

Open braunm opened this issue 7 years ago • 1 comments

I think it would be useful for fbad_request() to be exported. This will aid in debugging, and offer some flexibility in using endpoints of the API that are not supported by the package (e.g., ad_studies).

It's one line of code: adding an @export statement before the function in fb_init.R, and using document() to update the NAMESPACE. With appropriate permissions, I can push a new branch and then make a pull request.

Thanks.

braunm avatar Mar 23 '18 21:03 braunm

I was considering this previously, but I think it's better to keep it private -- those devs who want to debug stuff or want to use not-supported API endpoints definitely know about :::, so although it would be a bit convenient for them, but would also cause more confusion for the less advanced users.

I will keep this ticket open, though, and depending on further feedback I'm open to changing my past decision :)

daroczig avatar Mar 24 '18 14:03 daroczig