rawspeed icon indicating copy to clipboard operation
rawspeed copied to clipboard
verified publisher icon darktable-org

Panasonic DC-S5M2 support (data only)

Open kmilos opened this issue 2 years ago • 10 comments

Partly addresses https://github.com/darktable-org/darktable/issues/13511 and https://github.com/darktable-org/darktable/issues/15446

Used ADC 15.2. Crop is unverified.

This depends on v8 decoder working.

kmilos avatar Feb 14 '23 08:02 kmilos

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.91%. Comparing base (13a3318) to head (55a242d). Report is 169 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #427   +/-   ##
========================================
  Coverage    60.91%   60.91%           
========================================
  Files          271      271           
  Lines        16366    16366           
  Branches      2077     2077           
========================================
  Hits          9969     9969           
  Misses        6268     6268           
  Partials       129      129
Flag Coverage Δ
benchmarks 11.84% <ø> (ø)
integration 45.05% <ø> (ø)
linux 57.10% <ø> (ø)
macOS 25.16% <ø> (ø)
rpu_u 45.05% <ø> (ø)
unittests 21.52% <ø> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 14 '23 08:02 codecov[bot]

Adding DC-S5M2X as alias (for testing? could/should be separated later?) - it's the same camera w/ additional FW capabilities: https://www.dpreview.com/reviews/panasonic-lumix-dc-s5-ii-dc-s5-iix-initial-review

Also verified the profile is the same in latest ADC 15.3 addition.

kmilos avatar Apr 18 '23 12:04 kmilos

Adding DC-S5M2X as alias (for testing? could/should be separated later?)

I have now separated DC-S5M2X as an independent model. More samples have been uploaded.

kmilos avatar Sep 18 '23 09:09 kmilos

Verified the samples. I suppose someone could try porting the v8 decoder from RT/libraw.

LebedevRI avatar Sep 18 '23 12:09 LebedevRI

I suppose someone could try porting the v8 decoder from RT/libraw.

Yes please @jdneumeyer77 😉

It's not public yet though AFAIK...

kmilos avatar Sep 18 '23 12:09 kmilos

@kmilos Happy to port it once it's publicly available. I don't own the GH6, S5ii or S5ii-x. So I'll use the samples.

jdneumeyer77 avatar Sep 18 '23 16:09 jdneumeyer77

@jdneumeyer77 yes, please.

LebedevRI avatar Feb 22 '24 17:02 LebedevRI

yes, please.

Still no public reference code available AFAIK 😞 (CC @mlouielu)

kmilos avatar Feb 22 '24 17:02 kmilos

cough adobe dng converter cough Ghidra cough

LebedevRI avatar Feb 22 '24 17:02 LebedevRI

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.91%. Comparing base (13a3318) to head (55a242d). Report is 203 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #427   +/-   ##
========================================
  Coverage    60.91%   60.91%           
========================================
  Files          271      271           
  Lines        16366    16366           
  Branches      2077     2077           
========================================
  Hits          9969     9969           
  Misses        6268     6268           
  Partials       129      129
Flag Coverage Δ
benchmarks 11.84% <ø> (ø)
integration 45.05% <ø> (ø)
linux 57.10% <ø> (ø)
macOS 25.16% <ø> (ø)
rpu_u 45.05% <ø> (ø)
unittests 21.52% <ø> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 24 '24 00:05 codecov-commenter