Fujifilm X-H2S Support

[etrigan63]

Please add support for uncompressed, lossless compressed and compressed raw files. I can submit raw files if needed. Just point me to where you want them.

[cytrinox]

Please upload the samples here: https://raw.pixls.us/

[etrigan63]

Done!

[kmilos]

Please try out adding the following to your cameras.xml and report what you find (most likely we'll have to update the crop and the CFA pattern arrangement):

	<Camera make="FUJIFILM" model="X-H2S">
		<ID make="Fujifilm" model="X-H2S">Fujifilm X-H2S</ID>
		<CFA2 width="6" height="6">
			<ColorRow y="0">GGRGGB</ColorRow>
			<ColorRow y="1">GGBGGR</ColorRow>
			<ColorRow y="2">BRGRBG</ColorRow>
			<ColorRow y="3">GGBGGR</ColorRow>
			<ColorRow y="4">GGRGGB</ColorRow>
			<ColorRow y="5">RBGBRG</ColorRow>
		</CFA2>
		<Crop x="0" y="6" width="-78" height="-12"/>
		<Sensor black="1024" white="16383"/>
		<ColorMatrices>
			<ColorMatrix planes="3">
				<ColorMatrixRow plane="0">12836 -5909 -1032</ColorMatrixRow>
				<ColorMatrixRow plane="1">-3087 11132 2236</ColorMatrixRow>
				<ColorMatrixRow plane="2">-35 872 5330</ColorMatrixRow>
			</ColorMatrix>
		</ColorMatrices>
	</Camera> 
	<Camera make="FUJIFILM" model="X-H2S" mode="compressed">
		<ID make="Fujifilm" model="X-H2S">Fujifilm X-H2S</ID>
		<CFA2 width="6" height="6">
			<ColorRow y="0">GGRGGB</ColorRow>
			<ColorRow y="1">GGBGGR</ColorRow>
			<ColorRow y="2">BRGRBG</ColorRow>
			<ColorRow y="3">GGBGGR</ColorRow>
			<ColorRow y="4">GGRGGB</ColorRow>
			<ColorRow y="5">RBGBRG</ColorRow>
		</CFA2>
		<Crop x="0" y="6" width="-78" height="-12"/>
		<Sensor black="1024" white="16383"/>
		<ColorMatrices>
			<ColorMatrix planes="3">
				<ColorMatrixRow plane="0">12836 -5909 -1032</ColorMatrixRow>
				<ColorMatrixRow plane="1">-3087 11132 2236</ColorMatrixRow>
				<ColorMatrixRow plane="2">-35 872 5330</ColorMatrixRow>
			</ColorMatrix>
		</ColorMatrices>
	</Camera> 

Probably the "new" lossy compressed mode is not yet supported, like it is still the case w/ T4, E4, S10, etc...

[etrigan63]

No error message, but the image is either blank white or magenta. [image: image.png] [image: photo] Carlos Echenique Photographer at CE Photographic P 305.219.2433 <305.219.2433> E @.*** @.***> W cephotographic.com http://cephotographic.com http://instagram.com/cephotographic http://facebook.com/cephotos http://www.flickr.com/photos/echenique

"A day without sunshine is like, you know, night." - Steve Martin. Create your own email signature https://www.wisestamp.com/create-own-email-signature/?utm_source=promotion&utm_medium=signature&utm_campaign=create_your_own&srcid=

On Mon, Jul 4, 2022 at 5:54 AM Miloš Komarčević @.***> wrote:

Please try out adding the following to your cameras.xml and report what you find:

Fujifilm X-H2S BGGRGG GRBGBR BGGRGG RGGBGG GBRGRB RGGBGG 12836 -5909 -1032 -3087 11132 2236 -35 872 5330 Fujifilm X-H2S BGGRGG GRBGBR BGGRGG RGGBGG GBRGRB RGGBGG 12836 -5909 -1032 -3087 11132 2236 -35 872 5330

Probably the "new" lossy compressed mode is not yet supported, like it is the case w/ T4, E4, S10, etc...

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/rawspeed/issues/374#issuecomment-1173608311, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYBYQAWRVOKN253Q6KWVJTVSKYDXANCNFSM52MTS2AA . You are receiving this because you authored the thread.Message ID: @.***>

[kmilos]

I had already updated the settings above in the meantime, please give it a go again.

[cytrinox]

Only two samples uploaded, but H2S supports 3 modes (uncompresses, lossless, compressed). Please uploaded the missing sample, too.

[etrigan63]

I had already updated the settings above in the meantime, please give it a go again.

This one is much better. Colors are correct. Filmic RGB underexposes an additional stop. Small crop is needed due to sensor size difference. This is more pronounced if manual lens correction is applied. lensfun will need an update for the sensor.

[etrigan63]

Only two samples uploaded, but H2S supports 3 modes (uncompresses, lossless, compressed). Please uploaded the missing sample, too.

Lossy compressed sample uploaded.

I also uploaded three daylight shots.

[mwperina]

Hi, I've tried to append above code into cameras.xml, but when I'm trying to open uncompressed RAF file in Darkroom, following error is shown:

`Fujifilm X-H2S' color matrix not found!

I'm using Darktable 3.8.1 on Fedora 35.

Is there anything I can help with to include X-H2S support into Darktable?

Thanks, Martin

[kmilos]

This approach works only from dt 4.0

[etrigan63]

The XML provided no longer works as of dt 4.0.1. The X-H2S firmware updated to 2.0 but i don't think they changed the file format.

[mwperina]

After upgrade to Darktable 4.0.1 I can import uncompressed RAF from X-H2S without any problem and after working on more than 50 photos I haven't found any obvious issue, images are processed fine. So is there anything blocking us from getting X-H2S support merged?