lua-scripts icon indicating copy to clipboard operation
lua-scripts copied to clipboard

Copy dtMediaWiki v44 from trougnouf/dtMediaWiki

Open trougnouf opened this issue 6 years ago • 6 comments

dtMediaWiki adds Wikimedia Commons as a target storage. Latest documentation on https://commons.wikimedia.org/wiki/Commons:DtMediaWiki

trougnouf avatar Mar 16 '19 16:03 trougnouf

@supertobi I think @trougnouf has just triggered the next step(s) in the evolution of the lua-scripts repository. Here's what I think needs addressed:

  1. luarocks dependency. Currently we have one script that has a requirement for an external library and we've just kind of ignored it and left it up to the user to resolve. I've avoided using external lua dependencies because I could and I didn't want to figure it out at the time. I think the time has come to address it.

  2. script documentation. Currently we don't really have a good method of addressing script documentation. I rip the beginning comments from the scripts to use in the tooltips for script_manager, but that's the only script documentation that's available. Perhaps markdown formatted files in a doc directory?

  3. scripts in subdirectories. I'm currently working on the plugin API, which envisions each plugin in it's own directory. However, the plugin API is nowhere close to ready. A script in a subdirectory will probably break script_manager at the worst, or at the best it will just get ignored. One solution is to split this up and put the README.md in a doc directory, the MediaWikiAPI.lua in the lib directory, and dtMediaWiki.lua in the contrib directory. Or, I can change script manager to correctly handle scripts in subdirectories. I guess the real question is what do we want the repository tree to look like?

I propose opening issues for each of the above so that we can address them in their own thread.

@trougnouf could you point us at a page that has been populated using this script so that we can see what the output looks like? Thanks

wpferguson avatar Mar 17 '19 00:03 wpferguson

@wpferguson All files uploaded with the plugin are added to Uploaded_with_dtMediaWiki. File:SNCB_978_leaving_the_Ronet_classification_yard_(DSCF5536).jpg probably uses the latest revision (and makes uses the "other versions" feature).

trougnouf avatar Mar 17 '19 00:03 trougnouf

  1. I'm not a really big fan of all the script repositories (luarocks, CPAN, note.js, ...) not managed from the standard system way to install software. On the other hand it brings a lot of power and we should not block them.
  2. Subfolder or document folder? I like subfolders more. Have you tested it with your script manager?

supertobi avatar Mar 27 '19 21:03 supertobi

Any feedback as to why this was rejected?

trougnouf avatar Mar 29 '24 20:03 trougnouf

Any feedback as to why this was rejected?

It had the label waiting for feedback and it had been almost 4 years so I assumed that you had lost interest (and I finally got around to some house cleaning). Now that I opened it, I see where you pushed some commits, so my bad for assuming.

I'll reopen it and we'll see if we can get it finished.

wpferguson avatar Mar 29 '24 22:03 wpferguson

Any feedback as to why this was rejected?

It had the label waiting for feedback and it had been almost 4 years so I assumed that you had lost interest (and I finally got around to some house cleaning). Now that I opened it, I see where you pushed some commits, so my bad for assuming.

I'll reopen it and we'll see if we can get it finished.

I think I addressed everything I can at the time.

I just pushed an update to the latest commit from my repo.

trougnouf avatar Mar 29 '24 23:03 trougnouf