darktable icon indicating copy to clipboard operation
darktable copied to clipboard

retouch wavelet decomposition & colorpicker in fill color mode: color box doesn't show picked color

Open MStraeten opened this issue 4 years ago • 11 comments

color of the picker isn't identical to the color the picker is over image

at least painting around with the color in fill mode uses the color the picker was over, not the color displayed in the color box

  • darktable version : 3.5.0+2120~g3c608f9a95-dirty
  • OS : OSx

MStraeten avatar May 08 '21 09:05 MStraeten

did some further investigations. The color Layer of the wavelet decomposition seems to encode colors in a strange way:

image: image retouch color layer: image

MStraeten avatar May 11 '21 12:05 MStraeten

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jun 11 '21 00:06 github-actions[bot]

still reproducible with current master

MStraeten avatar Nov 16 '21 18:11 MStraeten

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jan 16 '22 00:01 github-actions[bot]

keeps being reproducible with darktable 4.1.0+1033~g688a4ae04

MStraeten avatar Nov 18 '22 12:11 MStraeten

keeps being reproducible with 4.3.0+1939~g8eb9ad90ba

MStraeten avatar Apr 23 '23 13:04 MStraeten

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Jun 23 '23 00:06 github-actions[bot]

If I understand your issue correctly, you want to be able to pick a color from the residual layer of the wavelet decomposition?

As far as the "strange encoding", the residual layer is literally what is left after subtracting off all of the wavelet layers, which makes each pixel basically the average color of a square 2**layers pixels on a side. It's still in the pixelpipe's working color space.

ralfbrown avatar Jan 11 '24 16:01 ralfbrown

yes, i enable the display of the residual layer and pick a color - but the picked "fill color" doesn't match the displayed color.

For me it doesn't make sense to process the residual layer preview with the later modules in the pixel pipe - what you see isn't what you get

MStraeten avatar Jan 11 '24 20:01 MStraeten

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar Mar 13 '24 00:03 github-actions[bot]

For me it doesn't make sense to process the residual layer preview with the later modules in the pixel pipe - what you see isn't what you get

Agreed. I ran into this today. I just started learning the retouch -> fill tool and the picked "fill color" not matching the displayed color has thrown me off, eg, picking very pale skin tone the displayed color is almost black.

vredesbyyrd avatar Mar 17 '24 01:03 vredesbyyrd

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

github-actions[bot] avatar May 17 '24 00:05 github-actions[bot]

This issue was closed because it has been inactive for 300 days since being marked as stale. Please check if the newest release or nightly build has it fixed. Please, create a new issue if the issue is not fixed.

github-actions[bot] avatar Mar 13 '25 00:03 github-actions[bot]