rotation and perspective" module not compatible with "retouching".

[cjose38]

Describe the bug

when using "rotation and perspective" with the "original framing" option, areas outside the selection are no longer available to the "retouch" module when the module is closed. screenshots and attached image + xmp file. if the "automatic cropping" option is deactivated, it works correctly.

Steps to reproduce

use the file with its xmp as a zip file. activate and deactivate the "rotation and perspective" module with and without the automatic cropping option.

Expected behavior

DT should have the same result with and without the "auto crop" option.

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.8.1

What OS are you using?

Windows

What is the version of your OS?

w10 pro

Describe your system?

No response

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

NVIDIA geforce RTX 3060 12 gb

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

rawxmp.zip

[ralfbrown]

That's expected behavior when r&p is before retouch in the pipeline - the cropped-away data doesn't get sent down the pipeline, so retouch can't see it. That's why the crop module comes after r&p by default, so that the data it crops away is available to retouch.

If you need some of the cropped-away area as source material in retouch, you can either turn off automatic cropping and manually crop, or use Ctrl-Shift-Drag to move r&p above retouch.

[cjose38]

I've tried moving R&P above "retouching" but it's not accepted.

[ralfbrown]

Hmm, interesting. Can reproduce, but you can move retouch down. That puts it before orientation, which might not be desirable, in which case you can achieve the desired result by moving r&p to just below retouch and then moving retouch down.

There are some "fences" preventing modules from being moved to places where they can't work, e.g. most modules before demosaic can't move after because there are different kinds of data in the pipe before/after demosaic. Presumably the one for retouch needs adjusting.

[pehar1]

you can achieve the desired result by moving r&p to just below retouch and then moving retouch down.

If I correctly understand you then have :

• ...
• exposure
• rotate and perspective
• retouch
• orientation
• chromatic abberations
• ...

but this will no longer work if you change a parameter in "orientation". The longer I think about it, the more I come to the conclusion that there is no "correct" module order in this case. The "cleanest" solution is to turn off automatic cropping in "rotate and perspective" and cropping with "crop" module, leaving the module order at default for RAW input.

[github-actions[bot]]

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

[ralfbrown]

No further followup in four months, so the mentioned workaround seems to have been satisfactory.