darktable icon indicating copy to clipboard operation
darktable copied to clipboard

Implement softproofing cmyk histogram

Open jenshannoschwalm opened this issue 1 year ago • 2 comments

While using a cmyk profile for histograms we had to fallback to a rgb profile supported in _transform_rgb_to_rgb_lcms2.

Instead of doing so we properly check for a cmyk to-profile, if so we use a softproofing xtrans operator instead inside _transform_rgb_to_rgb_lcms2.

jenshannoschwalm avatar May 07 '24 07:05 jenshannoschwalm

@jenshannoschwalm : A conflict resolution is needed here. TIA.

TurboGit avatar May 07 '24 16:05 TurboGit

Release note: Added support for CMYK profiled histogram

jenshannoschwalm avatar May 08 '24 06:05 jenshannoschwalm

I'm trying to use this with a cmyk soft-proof profile provided by Bay Photo and, while the histogram is showing now (thanks for the great work on that!), there is nothing in the vectorscope (see image). Is this expected behavior at this point, or should I open a new ticket?

Screenshot is from v4.9.0, but I've seen it on 4.8.0 as well.

image

johnlb avatar Jun 18 '24 14:06 johnlb

Please share the profile, will have a look.

jenshannoschwalm avatar Jun 18 '24 15:06 jenshannoschwalm

Had to put it in a zip file to upload, but here ya go.

BayPhoto_MetalPrints.zip

johnlb avatar Jun 18 '24 16:06 johnlb

Thanks, it seems it sometimes works sometimes it doesn't. Will check

jenshannoschwalm avatar Jun 18 '24 17:06 jenshannoschwalm

Oh huh. I haven't seen it work at all yet. When you say sometimes it works, are you toggling between soft proofing on/off or switching between histogram modes or something?

On Tue, Jun 18, 2024, 10:42 AM Hanno Schwalm @.***> wrote:

Thanks, it seems it sometimes works sometimes it doesn't. Will check

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/darktable/pull/16751#issuecomment-2176641342, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHBEPZJC2EHNLEHNV3RZZTZIBWR5AVCNFSM6AAAAABHKNTMGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZWGY2DCMZUGI . You are receiving this because you commented.Message ID: @.***>

johnlb avatar Jun 18 '24 19:06 johnlb

It seems to work safely with this Bildschirmfoto vom 2024-06-18 22-53-05

EDIT: for some reason i don't yet understand (likely some vectorscope magic) this only works in RYB mode.

jenshannoschwalm avatar Jun 18 '24 20:06 jenshannoschwalm