darktable icon indicating copy to clipboard operation
darktable copied to clipboard

FR: add picker to color equalizer

Open elstoc opened this issue 2 years ago • 6 comments

I've been experimenting with using the color equalizer for monochrome conversion. The pattern I've settled on is to add a second instance of color calibration (with a grey preset) after the color equalizer and then use the sliders on the brightness tab to adjust the tones.

Since when I do this I can't see the colours (unless I enable a snapshot) it would be really useful if there was a color picker I could use to select part of the image and have the picked section show up on the graph (as you can with color zones).

elstoc avatar Feb 06 '24 21:02 elstoc

I see the point, yet not sure how this should be visualized exactly

jenshannoschwalm avatar Mar 15 '24 06:03 jenshannoschwalm

An area picker might be hard to do here but a spot picker should be able to show a line on the graph representing the colour of the mask at that point.

elstoc avatar Mar 15 '24 07:03 elstoc

I was less thinking about technical stuff but: what is good support for the mentioned workflow.

Leaving out the on-canvas way - as in tone equalizer - that would be very tricky for this module.

Maybe the other way round, while the mouse is over the module widget visualize corresponding pixels in the canvas? And maybe with some button pressed?

jenshannoschwalm avatar Mar 15 '24 10:03 jenshannoschwalm

That sounds like a nice idea, though I'm not sure whether it's better for my use case or not, and you'd want something like that to show the mask for the range covered by a node (with a falloff in mask intensity representative of the shape the graph would be if you just changed that node). For me the use case (for B&W conversion) is probably more "I want to alter the brightness of feature X, and would want to pick that feature to see which graph node I'd need to pull". What you suggest would work for that but might need a bit more trial-and-error to find the correct node.

I agree that on-canvas modification of the graph is probably impractical.

elstoc avatar Mar 15 '24 12:03 elstoc

OK. Maybe discuss any tool like a picker - or whatever we want - also in the "remaining issues" thread so we cover more use cases?

jenshannoschwalm avatar Mar 15 '24 14:03 jenshannoschwalm

Happy to link it there but I think I'd prefer to keep features/discussions separate to avoid threads getting lost.

elstoc avatar Mar 15 '24 14:03 elstoc