darktable icon indicating copy to clipboard operation
darktable copied to clipboard

Migration of button-pressed and button-released to new GtkGesture API.

Open Christian-Kr opened this issue 2 years ago • 1 comments

Hello to everyone,

this pr will migrate the first button-pressed and button-release to the new GtkGesture API. Please test if everything is working as before. I do not find any problem but I also might have missed something.

I will wait with all further migration to this event context, until this pr has been reviewed. This is because I want to be sure, that the way I implemented it is your preferred way and I don't need to do things twice. :-)

Just to let all of you know: I am coming from the cpp perspective. This might break some things in code structure in the way I prefer to implement it.

Looking forward to your reply. Thanks in advance

Greetings

Christian-Kr avatar Dec 21 '23 18:12 Christian-Kr

@Christian-Kr : Please do not merge master into topic branches. I'd prefer a rebase when needed. TIA.

TurboGit avatar Dec 23 '23 11:12 TurboGit

@Christian-Kr : Please do not merge master into topic branches. I'd prefer a rebase when needed. TIA.

@TurboGit : I have reset the merge commit and force-pushed the branch to remote. In future I will use rebase. I would also handle #15908 like that, if it is ok for you.

Greetings

Christian-Kr avatar Jun 01 '24 11:06 Christian-Kr

Well, there was some additional conflict with rebase. I think I ruined it. Cause it was just a small change, I will close this pr and start with a fresh branch again.

Sry for that.

Christian-Kr avatar Jun 01 '24 17:06 Christian-Kr