lenis icon indicating copy to clipboard operation
lenis copied to clipboard

fix: add lenis-svelte to the list of plugins

Open DaniAcu opened this issue 1 year ago • 6 comments

I'm started working on svelte, and I notice lenis doesn't have a wrapper for svelte like it does for nuxt and vue. So I create the package.

If you are okay with adding this package here it will be really helpful for future svelte developer that are trying to use this awesome library in their projects.

DaniAcu avatar Aug 02 '24 19:08 DaniAcu

@DaniAcu is attempting to deploy a commit to the darkroom Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 02 '24 19:08 vercel[bot]

Thanks @DaniAcu, what do you think about working on lenis/svelte ?

clementroche avatar Aug 02 '24 20:08 clementroche

@clementroche do you mean inside this package? It will be great, I could create another PR to move the lib here.

I have a couple questions,

  • can I still add me as an author in the package.json?
  • I will be not having a svelte playground to show use cases, do you prefer that I add a public codesandbox for that and add it to the documentation?
  • How the publish version of lenis/svelte will works? You are doing it manually, I can be able to push a new version from my own?

DaniAcu avatar Aug 03 '24 12:08 DaniAcu

  • yes, we could add you as contributors https://docs.npmjs.com/cli/v10/configuring-npm/package-json#people-fields-author-contributors
  • as you want as long as it's located into /packages/svelte
  • we only allow our internal team to publish new versions for security reasons so you'll have to PR first.

clementroche avatar Aug 05 '24 17:08 clementroche

Okay, I will move the package here. Do you want to have any other framework wrapper?

DaniAcu avatar Aug 05 '24 22:08 DaniAcu

vue

clementroche avatar Aug 05 '24 22:08 clementroche

Hello, I have created a Svelte5 binding as a preview for future versions. https://github.com/richhost/svelte-lenis

richhost avatar Oct 05 '24 15:10 richhost

Sorry for the delay @clementroche I will close this PR in favor of this https://github.com/darkroomengineering/lenis/pull/390.

DaniAcu avatar Oct 06 '24 17:10 DaniAcu