dapr
WIP: Add Jobs API
Description
Add Jobs API
Issue reference
Please reference the issue this PR will close: #1101
Checklist
- [ ] Code compiles correctly
- [ ] Created/updated tests
- [ ] Extended the documentation
@cicoyle I have added scheduleJob API, can you please review once If my approach is right
@charan2628 I've added more feedback here.. let me know if that makes sense.
Gentle ping @charan2628 - did you address the above? Do you need any assistance?
Gentle ping @charan2628 - did you address the above? Do you need any assistance? I doing the changes, will push this week
@salaboy @artur-ciocanu I have done the changes mentioned for ScheduleJob API and implemented Delete and GetJob APIs, please review it.
Hi @charan2628 - mind checking out this dotnet-sdk Jobs API implementation PR and align us more with the implementation there? We should include similar validation and builder patterns for cron expressions. For instance, we will need several tests added to confirm the functionality from this PR - can you add explicit integration tests for the Jobs API? We will want to test for: cron expression schedules, one-time job schedules, and recurring schedules. We will likely need a cron expression builder as well, so definitely check out their implementation/validation.
Ok @cicoyle I will do that.
@cicoyle I will modify the code to use JobSchedule once @siri-varma PR is merged, he impleted JobSchedule.
@charan2628 we should close this one as this is covered by this PR -> https://github.com/dapr/java-sdk/pull/1255 right?
@charan2628 we should close this one as this is covered by this PR -> #1255 right?
Yes :( @salaboy
Thank you for your efforts @charan2628 - I will close this PR since this Jobs API PR got merged and pushed the logic over the finish line. Appreciate the efforts here and getting a start on it 🙏🏻