daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-11204 dfs: Resample file stat after changing size.

Open ashleypittman opened this issue 3 years ago • 1 comments

  • DAOS-11204 dfs: Resample file stat after changing size.
  • Enable test.

ashleypittman avatar Aug 09 '22 08:08 ashleypittman

Bug-tracker data: Ticket title is 'dfuse mtime incorrect with caching' Status is 'In Review' Labels: 'triaged' https://daosio.atlassian.net/browse/DAOS-11204

github-actions[bot] avatar Aug 09 '22 08:08 github-actions[bot]

Just a note it looks like this PR has conflicts now.

kprantis avatar Aug 16 '22 16:08 kprantis

I'm waiting for https://github.com/daos-stack/daos/pull/9778 to land before working in this as then I can enable the tests in this PR.

ashleypittman avatar Aug 16 '22 16:08 ashleypittman

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9943/2/execution/node/138/log

daosbuild1 avatar Aug 24 '22 14:08 daosbuild1

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9943/3/execution/node/146/log

daosbuild1 avatar Aug 24 '22 14:08 daosbuild1

@ashleypittman when you land this, please backport to 2.2

mchaarawi avatar Aug 25 '22 16:08 mchaarawi

@ashleypittman when you land this, please backport to 2.2

The dfuse unit tests aren't on 2.2 so this won't be a clean cherry-pick but I'll backport it.

ashleypittman avatar Aug 25 '22 16:08 ashleypittman

The dfuse unit tests aren't on 2.2 so this won't be a clean cherry-pick but I'll backport it.

is there a reason not to backport those tests too?

mchaarawi avatar Aug 25 '22 16:08 mchaarawi

The dfuse unit tests aren't on 2.2 so this won't be a clean cherry-pick but I'll backport it.

is there a reason not to backport those tests too?

We looked at this yesterday, they use a avocado !mux feature which needed a bunch of python3 patches to launch.py so a backport is non-trivial.

ashleypittman avatar Aug 25 '22 17:08 ashleypittman

The dfuse unit tests aren't on 2.2 so this won't be a clean cherry-pick but I'll backport it.

is there a reason not to backport those tests too?

See my comment here: https://daosio.atlassian.net/browse/DAOS-11171

daltonbohning avatar Aug 25 '22 17:08 daltonbohning

The dfuse unit tests aren't on 2.2 so this won't be a clean cherry-pick but I'll backport it.

is there a reason not to backport those tests too?

See my comment here: https://daosio.atlassian.net/browse/DAOS-11171

It would be great to keep track and backport all the required test. it sounds concerning if we don't backport tests just because of the test infrastructure.

mchaarawi avatar Aug 25 '22 17:08 mchaarawi

We DO want to backport the tests - it's just going to be complicated :)

daltonbohning avatar Aug 25 '22 17:08 daltonbohning

We DO want to backport the tests - it's just going to be complicated :)

got it. thanks!

mchaarawi avatar Aug 25 '22 17:08 mchaarawi