daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-7821 gha: Remove pylint from checks.

Open ashleypittman opened this issue 3 years ago • 4 comments

This should all be handled via github actions now, so remove from Jenkins.

Signed-off-by: Ashley Pittman [email protected]

ashleypittman avatar Aug 09 '22 08:08 ashleypittman

Bug-tracker data: Ticket title is 'Improve github actions integration.' Status is 'In Progress' https://daosio.atlassian.net/browse/DAOS-7821

github-actions[bot] avatar Aug 09 '22 08:08 github-actions[bot]

Should be reviewed in combination with https://github.com/daos-stack/code_review/pull/31 I think these PRs are correct for master and disable all codespell and pylint checks from Jenkins but will have the side effect of also removing them for other branches (both release and feature). I can't think of a way around this without compromising the master tree however, perhaps the code-review change could check for the existence of utils/cq/daos_pylint.py?

The github actions checks for codespell and pylint should be feature compatible with Jenkins now although there are slight differences because of various settings and the way issues are reported.

ashleypittman avatar Aug 09 '22 10:08 ashleypittman

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9942/3/execution/node/167/log

daosbuild1 avatar Aug 11 '22 14:08 daosbuild1

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9942/4/execution/node/144/log

daosbuild1 avatar Aug 11 '22 16:08 daosbuild1

ashleypittman force-pushed the amd/no-pylint branch from f261d19 to 5eacf0f

Please try to remember not to force push once reviewing has started.

brianjmurrell avatar Sep 03 '22 14:09 brianjmurrell

Test stage Unit Test on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9942/10/execution/node/618/log

daosbuild1 avatar Sep 05 '22 09:09 daosbuild1