daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-623 build: Update Protobuf compiler reference

Open emmanuel-ferdman opened this issue 9 months ago • 5 comments

PR Summary

Small PR - Commit d7261a68787d15cc7a8db73c8b3a81ab53f040e7 moved development.md to docs. This PR adjusts sources to changes.

Steps for the author:

  • [x] Commit message follows the guidelines.
  • [ ] Appropriate Features or Test-tag pragmas were used.
  • [ ] Appropriate Functional Test Stages were run.
  • [ ] At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • [ ] Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • [ ] Gatekeeper requested (daos-gatekeeper added as a reviewer).

emmanuel-ferdman avatar Apr 29 '25 16:04 emmanuel-ferdman

Ticket title is 'Generic ticket for minor code cleanup and improvement' Status is 'Resolved' Labels: 'request_for_2.6.4' https://daosio.atlassian.net/browse/DAOS-623

github-actions[bot] avatar Apr 29 '25 16:04 github-actions[bot]

@daltonbohning is anything else is needed from my side? thanks 😄

emmanuel-ferdman avatar Jun 09 '25 21:06 emmanuel-ferdman

@daltonbohning is anything else is needed from my side? thanks 😄

We need 2 approvals before merging. I added some more people.

daltonbohning avatar Jun 09 '25 22:06 daltonbohning

Oh, I think also for the GitHub Actions to run, the branch needs to be in the daos-stack/daos repo, not a fork

daltonbohning avatar Jun 09 '25 22:06 daltonbohning

@emmanuel-ferdman We're looking into the correct process on our side. Lots of folks out on vacation this week (US holiday), we will get back to you next week.

kjacque avatar Jul 03 '25 21:07 kjacque