daos icon indicating copy to clipboard operation
daos copied to clipboard
verified publisher icon daos-stack

DAOS-14226 docker: deployment of vcluster with md-on-ssd

Open knard38 opened this issue 2 years ago • 4 comments

Description

Update DAOS docker vcluster scripts for being able to deploy a minimal docker DAOS system using the md-on-ssd feature.

This PR also fix miscellaneous minor issues such as default DAOS rpms repos, variables naming, etc.

Validation

The Doc-only pragma as been used as there is nothing yet tested by the CI related to this docker stuff.

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

knard38 avatar Sep 25 '23 07:09 knard38

Bug-tracker data: Ticket title is 'Support of MD-on-SSD feature with DAOS docker vcluster' Status is 'In Progress' https://daosio.atlassian.net/browse/DAOS-14226

github-actions[bot] avatar Sep 25 '23 07:09 github-actions[bot]

  • [x] Fix shellchek of the daos-cm.sh bash script

knard38 avatar Nov 21 '23 10:11 knard38

Ticket title is 'Support of MD-on-SSD feature with DAOS docker vcluster' Status is 'In Review' Labels: 'scrubbed' https://daosio.atlassian.net/browse/DAOS-14226

github-actions[bot] avatar Mar 04 '24 08:03 github-actions[bot]

@wangshilong , the MD-on-SSD part of this PR is mainly located in the following file https://github.com/daos-stack/daos/pull/13087/files#diff-dafded59aac66322de0fbf042ad3e8d95963dda21189d96a6228ce1ee51bc864

knard38 avatar Mar 13 '24 09:03 knard38

I see you making use of .in files with the defacto-standard @…@ substitutions in them.

Interestingly enough as I was going through this PR noticing all of the much repeated version changes and so on throughout so many files I was wondering if we need to employ more templating such as .in files with those values as templatable replacements and then only have to change the literal values in one place and let templating do the grunt work.

  • [x] Use env variable for version number

knard38 avatar Mar 18 '24 13:03 knard38

I see you making use of .in files with the defacto-standard @…@ substitutions in them. Interestingly enough as I was going through this PR noticing all of the much repeated version changes and so on throughout so many files I was wondering if we need to employ more templating such as .in files with those values as templatable replacements and then only have to change the literal values in one place and let templating do the grunt work.

  • [x] Use env variable for version number

Fixed with commit e25d91c6d2fa642272df16b54ab50b2e221eb470

knard38 avatar Mar 20 '24 09:03 knard38

@wangshilong , @mark-olson and @brianjmurrell could you check if my latest modifications are answering your remarks. Thanks in advance, Cedric.

knard38 avatar Mar 25 '24 08:03 knard38

@daos-stack/daos-gatekeeper please could you land this PR with the description section paragraph as commit message.

knard38 avatar Mar 27 '24 07:03 knard38