DAOS-10819 log: limit redundant ERR level logging

[bfaccini]

There are redundant ERR level loging in Mercury, Cart and DAOS. This patch is an attempt to limit this between Cart and DAOS, a Mercury patch will also do it there.

Required-githooks: true

Before requesting gatekeeper:

• [x] Two review approvals and any prior change requests have been resolved.
• [x] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
• [ ] Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
• [x] Commit messages follows the guidelines outlined here.
• [x] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

• [ ] You are the appropriate gatekeeper to be landing the patch.
• [ ] The PR has 2 reviews by people familiar with the code, including appropriate watchers.
• [ ] Githooks were used. If not, request that user install them and check copyright dates.
• [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
• [ ] All builds have passed. Check non-required builds for any new compiler warnings.
• [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
• [ ] If applicable, the PR has addressed any potential version compatibility issues.
• [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
• [ ] Extra checks if forced landing is requested
  • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
  • [ ] No new NLT or valgrind warnings. Check the classic view.
  • [ ] Quick-build or Quick-functional is not used.
• [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

[github-actions[bot]]

Bug-tracker data: Ticket title is 'Reduce amount of errors printed to the server log when client with rdma died/ctrl-c' Status is 'In Review' Labels: 'triaged' Errors are Unknown component https://daosio.atlassian.net/browse/DAOS-10819

[bfaccini]

Any chance to review ??

[frostedcmos]

Any chance to review ??

This has a conflict and probably needs someone from a core daos team to review as it touches daos-level logic and not really cart.

[bfaccini]

Any chance to review ??

This has a conflict and probably needs someone from a core daos team to review as it touches daos-level logic and not really cart.

Ok, then adding @liw and @jolivier23 !

[bfaccini]

Since PR introduces a new log message, Allow-unstable-test: true must be used to force passing NLT CI stage ...

[bfaccini]

@frostedcmos , @soumagne , @jolivier23 , any chance to review ?

[github-actions[bot]]

Ticket title is 'Reduce amount of errors printed to the server log when client with rdma died/ctrl-c' Status is 'In Review' Labels: 'scrubbed_2.6,triaged' Errors are Unknown component https://daosio.atlassian.net/browse/DAOS-10819

[knard38]

@soumagne , @frostedcmos , @liw and @jolivier23 please could you have a look at this PR and tell me if there is still something to fix ? Thanks in advance.

[knard38]

@soumagne , @frostedcmos , @liuxuezhao and @jolivier23 please could you have a look at this PR and tell me if there is still something to fix ? Thanks in advance.

[knard38]

There is still some unexplained error triggered. I am going to investigate more deeply when these errors occurs.

[knard38]

Last CI runs are failing on NLT errors which seems relevant https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-11992/10/VM_test/New/ and https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-11992/11/VM_test/New/ From my understanding, these errors are generated by some client code passing too small buffer. I am going to check with @ashleypittman if they are expected and thus should be added in the NLT skip list.

[knard38]

@soumagne , @frostedcmos , @liuxuezhao, @jolivier23 and @liw please could you have a look at this PR and tell me if there is still something to fix ? Thanks in advance.

[frostedcmos]

@soumagne , @frostedcmos , @liuxuezhao, @jolivier23 and @liw please could you have a look at this PR and tell me if there is still something to fix ? Thanks in advance.

I dont think there is just one concrete set of changes for this ticket as there can be many scenarios of what fails when you ctrl-c, depending which code path its executing in at that time (e.g. its doing rdma transfer vs not). We've also been eliminating some of duplicate timeout and cancellation reporting recently in cart as well as aggregating timeouts that happen at the same time.

In the end the way to try it if its enough is to run some tools , ctrl-c out of them mid run and see the errors that get generated. if any appear duplicate or unneeded those would be a target for next elimination.

[knard38]

@soumagne , @frostedcmos , @liuxuezhao, @jolivier23 and @liw please could you have a look at this PR and tell me if there is still something to fix ? Thanks in advance.

I dont think there is just one concrete set of changes for this ticket as there can be many scenarios of what fails when you ctrl-c, depending which code path its executing in at that time (e.g. its doing rdma transfer vs not). We've also been eliminating some of duplicate timeout and cancellation reporting recently in cart as well as aggregating timeouts that happen at the same time.

In the end the way to try it if its enough is to run some tools , ctrl-c out of them mid run and see the errors that get generated. if any appear duplicate or unneeded those would be a target for next elimination.

@frostedcmos , from my understanding of your comments, this PR seems to be useless. If yes, I should probably close this PR and its related JIRA ticket.

[knard38]

This PR has been closed as it has became useless with latest modification of the CART DAOS code.